[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: avoid spurious failure when gcj is not installed

From: Jim Meyering
Subject: Re: [PATCH] tests: avoid spurious failure when gcj is not installed
Date: Sat, 25 Feb 2012 14:32:18 +0100

Stefano Lattarini wrote:
> The patch is OK, of course.  Extra kudos if you add a reference in the
> commit message to the commit where I broke the tests.

Hi Stefano,
Thanks for the explanation.

Here you go:
[BTW, if you like gitk's highlighting of SHA1 strings in logs, and
compile your own version of git once in a while, you might want to
carry this git patch:
It makes gitk also highlight the SHA1 part of more descriptive
strings like v1.11-2019-g4d2bf42 below.  This shows what it looks like: ]

>From 9888205813e24281527448d408b2e4e5075e2026 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 25 Feb 2012 12:37:25 +0100
Subject: [PATCH] tests: avoid spurious failure when gcj is not installed

* tests/ (GNU_GCJ, GNU_GCJFLAGS): Define.
* tests/ (do_subust): Add those to the list of
substituted symbols.
Introduced via the previous commit, v1.11-2019-g4d2bf42.
 tests/    |    2 ++
 tests/ |    2 ++
 2 files changed, 4 insertions(+)

diff --git a/tests/ b/tests/
index 3c8c9d2..b6d41c7 100644
--- a/tests/
+++ b/tests/
@@ -156,6 +156,8 @@ do_subst = sed \
   -e 's|@address@hidden|$(GNU_FFLAGS)|g' \
   -e 's|@address@hidden|$(GNU_FC)|g' \
   -e 's|@address@hidden|$(GNU_FCFLAGS)|g' \
+  -e 's|@address@hidden|$(GNU_GCJ)|g' \
+  -e 's|@address@hidden|$(GNU_GCJFLAGS)|g' \
   -e 's|@address@hidden|$(YACC)|g' \
   -e 's|@address@hidden|$(LEX)|g' \
   -e 's|@address@hidden|$(TEX)|g' \
diff --git a/tests/ b/tests/
index 6f79fe2..80cd1fe 100644
--- a/tests/
+++ b/tests/
@@ -205,6 +205,8 @@ 

 # No all versions of Tex support '--version', so we use a configure
 # check to decide if tex is available.  This decision is embodied in

reply via email to

[Prev in Thread] Current Thread [Next in Thread]