[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: do not clobber the modified CC

From: Stefano Lattarini
Subject: Re: [PATCH] tests: do not clobber the modified CC
Date: Tue, 06 Mar 2012 14:27:27 +0100

On 03/06/2012 02:23 PM, Peter Rosin wrote:
> Stefano Lattarini skrev 2012-03-06 14:11:
>> On 03/06/2012 01:53 PM, Peter Rosin wrote:
>>>> Subject: [PATCH] tests: do not clobber the modified CC
>> Maybe s|the modified CC|the $CC set by AM_PROG_CC_C_O (for losing compilers)|
>> here?
> Pushed with nits, but I dropped the "(for losing compilers)" part as the
> line became too long,
And in hindsight, it would have also been redundant with your "extended
explanation" in the body of the commit message.  So well done.

> and I also did s/CC/$CC/ for the rest of the commit message.
Thanks.  I didn't think of that, but the message reads better after this
substitution IMO.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]