[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works |
Date: |
Mon, 07 May 2012 22:08:40 +0200 |
On 05/07/2012 07:17 PM, Eric Blake wrote:
> On 05/01/2012 10:04 AM, Stefano Lattarini wrote:
>> After the last changes, configure will ensure that the shell
>> selected to run the test scripts can correctly propagate exit
>> status to the exit trap when 'set -e' is in effect.
>>
>> * configure.ac (sh_errexit_works): Do not AC_SUBST it anymore.
>> * defs-static.in (sh_errexit_works): Do not initialize
>> from the AC_SUBST value anymore.
>> * defs (trap): Trap the EXIT signal unconditionally.
>> * t/self-check-explicit-skips.sh: Do not skip the test if
>> '$sh_errexit_works' is != "yes", this check doesn't make
>> sense anymore.
>> * t/self-check-cleanup.tap: Likewise.
>> * t/self-check-exit.tap: Assume the exit trap is always
>> installed by ./defs.
>>
>> Signed-off-by: Stefano Lattarini <address@hidden>
>> ---
>> configure.ac | 3 ---
>> defs | 3 +--
>> defs-static.in | 3 ---
>> t/self-check-cleanup.tap | 4 ----
>> t/self-check-exit.tap | 13 +------------
>> t/self-check-explicit-skips.sh | 2 --
>> 6 files changed, 2 insertions(+), 26 deletions(-)
>
> Nice cleanups!
>
And I hope many more will appear soonish :-)
Regards,
Stefano
- [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell, Stefano Lattarini, 2012/05/01
- [PATCH 2/5] configure: search a sturdy POSIX shell to be used in the testsuite, Stefano Lattarini, 2012/05/01
- [PATCH 1/5] tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL, Stefano Lattarini, 2012/05/01
- [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works, Stefano Lattarini, 2012/05/01
- [PATCH 4/5] test defs: fix indentation (cosmetic change), Stefano Lattarini, 2012/05/01
- [PATCH 5/5] tests: fix a spurious failure with dash, Stefano Lattarini, 2012/05/01
- Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell, Eric Blake, 2012/05/01