[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [FYI] {maint} self tests: cater for /bin/ksh symlinked to Zsh
From: |
Dave Hart |
Subject: |
Re: [FYI] {maint} self tests: cater for /bin/ksh symlinked to Zsh |
Date: |
Wed, 16 May 2012 14:25:51 +0000 |
On Wed, May 16, 2012 at 2:11 PM, Stefano Lattarini
<address@hidden> wrote:
> * t/self-check-reexec.tap: When searching for a suitable non-Bash
> shells, be sure to reject any shell that is Zsh "in disguise" (as
> can be found on some Debian systems, where /bin/ksh can be symlinked
> to /bin/zsh4). This is required because our testsuite does not
> support older versions of Zsh if not imperfectly, and that was
s/if not imperfectly//
> causing the test to fail in the setup just described.
>
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
> t/self-check-reexec.tap | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/t/self-check-reexec.tap b/t/self-check-reexec.tap
> index 7b91008..72e66d2 100755
> --- a/t/self-check-reexec.tap
> +++ b/t/self-check-reexec.tap
> @@ -48,7 +48,12 @@ for non_bash_shell in \
> do
> test "$non_bash_shell" = : && break
> $non_bash_shell -c 'exit 0' || continue
> - $non_bash_shell -c 'test -n "$BASH_VERSION"' && continue
> + # Be sure to reject also any shell that is Zsh "in disguise" (as can
> + # be found on some Debian systems, where /bin/ksh can be symlinked to
> + # /bin/zsh4). This is required because our testsuite does not support
> + # older versions of Zsh if not imperfectly, and that has caused
Likewise.
> + # spurious failures in the past.
> + $non_bash_shell -c 'test -n "$ZSH_VERSION$BASH_VERSION"' && continue
> break
> done
>
> --
> 1.7.9.5
>
>
Cheers,
Dave Hart