[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] elisp: no need to "absolutize" $(srcdir) and $(builddir)
From: |
Jack Kelly |
Subject: |
Re: [PATCH 5/7] elisp: no need to "absolutize" $(srcdir) and $(builddir) ... |
Date: |
Sun, 15 Jul 2012 08:31:12 +1000 |
On Sun, Jul 15, 2012 at 7:51 AM, Stefano Lattarini
<address@hidden> wrote:
> * lib/am/lisp.am (.el.elc): ... here: we don't chdir around anyway,
> nor move or copy around our source '.el' files. Update comments,
> and re-wrap them while we are at it.
>
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
> lib/am/lisp.am | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/lib/am/lisp.am b/lib/am/lisp.am
> index ce87fb0..7326cb5 100644
> --- a/lib/am/lisp.am
> +++ b/lib/am/lisp.am
> @@ -23,16 +23,17 @@ endif %?INSTALL%
> ## ---------- ##
>
> .el.elc:
> -## We add $(abs_builddir) and $(abs_srcdir) to load-path, so that any
> -## .el files that $< depends upon can be found (including generated
> -## ones). Prefer files from the build directory to those from the source
> -## directory, in true VPATH spirit. The destination file is normally
> -## determined by appending "c" to the input (which would erronously put
> -## it in $(srcdir) in VPATH builds), so we override that, too.
> +## We add $(builddir) and $(srcdir) to load-path, so that any '.el' files
> +## that $< depends upon can be found (including generated ones).
> +## We Prefer files from the build directory to those from the source
Nit: Capital on `Prefer'.
> +## directory, in true VPATH spirit.
> +## The destination file is normally determined by appending "c" to the
> +## input (which would erronously put it in $(srcdir) in VPATH builds), so
> +## we override that, too.
> if test "$(EMACS)" != "no"; then \
> $(EMACS) -q --batch \
> - --eval "(setq load-path (cons \"$(abs_srcdir)\" load-path))" \
> - --eval "(setq load-path (cons \"$(abs_builddir)\" load-path))" \
> + --eval "(setq load-path (cons \"$(srcdir)\" load-path))" \
> + --eval "(setq load-path (cons \"$(builddir)\" load-path))" \
> --eval "(defun byte-compile-dest-file (f) \"address@hidden")" \
> --eval "(unless (byte-compile-file \"$<\") (kill-emacs 1))"; \
> else :; fi
> --
> 1.7.9.5
>
>
- Refactoring elisp compilation, Jack Kelly, 2012/07/14
- Re: Refactoring elisp compilation, Stefano Lattarini, 2012/07/14
- [PATCH 0/7] More work on elisp support, Stefano Lattarini, 2012/07/14
- [PATCH 1/7] coverage: emacs lisp files in subdirectories, Stefano Lattarini, 2012/07/14
- [PATCH 2/7] coverage: elisp path contains $(srcdir) and $(builddir), Stefano Lattarini, 2012/07/14
- [PATCH 3/7] elisp: use suffix rules, get rid of 'elisp-comp' script (mostly a rewrite), Stefano Lattarini, 2012/07/14
- [PATCH 4/7] elisp: prefer $(builddir) files over $(srcdir) ones, Stefano Lattarini, 2012/07/14
- [PATCH 5/7] elisp: no need to "absolutize" $(srcdir) and $(builddir) ..., Stefano Lattarini, 2012/07/14
- Re: [PATCH 5/7] elisp: no need to "absolutize" $(srcdir) and $(builddir) ...,
Jack Kelly <=
- Re: [PATCH 5/7] elisp: no need to "absolutize" $(srcdir) and $(builddir) ..., Stefano Lattarini, 2012/07/15
- [PATCH 7/7] elisp: support elisp files in subdirectories properly, Stefano Lattarini, 2012/07/14
- [PATCH 6/7] elisp: simplify suffix rules using emacs '-L' option, Stefano Lattarini, 2012/07/14
- Re: Refactoring elisp compilation, Jack Kelly, 2012/07/14
- Re: Refactoring elisp compilation, Stefano Lattarini, 2012/07/15
- Re: Refactoring elisp compilation, Jack Kelly, 2012/07/17
- Re: Refactoring elisp compilation, Stefano Lattarini, 2012/07/17
- Re: Refactoring elisp compilation, Jack Kelly, 2012/07/23
- Re: Refactoring elisp compilation, Stefano Lattarini, 2012/07/23
- Re: Refactoring elisp compilation, Jack Kelly, 2012/07/23