Re: Add missing '$' for variable expansion in depout.m4

[Nick Bowler]

On 2013-04-11 19:12 +0100, Gavin Smith wrote:
> (I hope I have prepared this patch properly.)
> 
>     Add missing '$' for variable expansion in depout.m4
> 
>     * m4/depout.m4: "am__include" appeared where "$am__include" was meant.
> 
> diff --git a/m4/depout.m4 b/m4/depout.m4
> index 880a597..c79d04b 100644
> --- a/m4/depout.m4
> +++ b/m4/depout.m4
> @@ -40,7 +40,7 @@ AC_DEFUN([_AM_OUTPUT_DEPENDENCY_COMMANDS],
>      DEPDIR=`sed -n 's/^DEPDIR = //p' < "$mf"`
>      test -z "$DEPDIR" && continue
>      am__include=`sed -n 's/^am__include = //p' < "$mf"`
> -    test -z "am__include" && continue
> +    test -z "$am__include" && continue

Well-spotted!  This definitely looks like a mistake.  How did you
find this?

The test appears to have been defective ever since it was introduced
almost 10 years ago.  At this point, it may be better to simply remove
the dead code entirely unless this is known to fix a real problem.

Cheers,
-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)