[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[FYI] {micro} t/README: document "run_make", discourage "make -e"
From: |
Stefano Lattarini |
Subject: |
[FYI] {micro} t/README: document "run_make", discourage "make -e" |
Date: |
Wed, 29 May 2013 14:16:55 +0200 |
Signed-off-by: Stefano Lattarini <address@hidden>
---
t/README | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/t/README b/t/README
index 60eb7c7..23dd943 100644
--- a/t/README
+++ b/t/README
@@ -200,6 +200,24 @@ Writing test cases
$PERL, $MAKE, $EGREP, and $FGREP, instead of the corresponding
commands.
+* When you want to redirect the output from a make invocation, use the
+ 'run_make' function rather than calling $MAKE directly. Not only is
+ this more idiomatic, but it also avoid possible spurious racy failures
+ when the make invocations in the testsuite are run in parallel mode
+ (as with "make check AM_TESTSUITE_MAKE='make -j4"').
+
+* Do not override Makefile variables using make arguments, as in e.g.:
+
+ $MAKE prefix=/opt install # BAD
+
+ This is not portable for recursive targets (with non-GNU make,
+ targets that call a sub-make may not pass "prefix=/opt" along).
+ Instead, use the 'run_make' function, which automatically uses
+ the AM_MAKEFLAGS to propagate the variable definitions along to
+ sub-make:
+
+ run_make prefix=/opt install # GOOD
+
* Use '$sleep' when you have to make sure that some file is newer
than another.
@@ -283,13 +301,3 @@ Writing test cases
Note this doesn't prevent the test from failing for another reason,
but at least it makes sure the original error is still here.
-
-* Do not override Makefile variables using make arguments, as in e.g.:
-
- $MAKE prefix=/opt install
-
- This is not portable for recursive targets (targets that call a
- sub-make may not pass "prefix=/opt" along). Use the following
- instead:
-
- prefix=/opt $MAKE -e install
--
1.8.3.rc3.8.g5e49f30
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [FYI] {micro} t/README: document "run_make", discourage "make -e",
Stefano Lattarini <=