[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Another BSD make incompatibility

From: Derek R. Price
Subject: [PATCH] Another BSD make incompatibility
Date: Wed, 03 Jan 2001 08:33:23 -0500

Found another bug in automake's support for dependencies using BSD's make.  This
one is based on the fact that BSD make doesn't allow comments to continue on the
next line using '\'.  I just hooked into the existing conditional machinery
instead of stuffing "address@hidden@" as the first item in the DEP_FILES list, 
as used
to happen.

There're new RPMs at:


Derek Price                      CVS Solutions Architect ( )
mailto:address@hidden     OpenAvenue ( )
I find that the harder I work, the more luck I seem to have.

                        - Thomas Jefferson

RCS file: /cvs/automake/automake/,v
retrieving revision 1.813
diff -u -r1.813
--- 2000/12/23 21:05:21     1.813
+++ 2000/12/29 20:30:22
@@ -3030,7 +3031,7 @@
            local ($iter);
            local (@deplist) = sort keys %dep_files;
-           &define_pretty_variable ('DEP_FILES', '', ("address@hidden@", 
+           &define_pretty_variable ('DEP_FILES', "address@hidden@", @deplist);
            # Generate each `include' individually.  Irix 6 make will
            # not properly include several files resulting from a
Index: ChangeLog
RCS file: /cvs/automake/automake/ChangeLog,v
retrieving revision 1.929
diff -u -r1.929 ChangeLog
--- ChangeLog   2000/12/23 21:42:43     1.929
+++ ChangeLog   2000/12/29 20:38:49
@@ -1,3 +1,11 @@
+2000-12-29  Derek Price  <address@hidden>
+       * (handle_dependencies): switched the DEP_FILES definition
+       to use the &pretty_print conditional machinery rather than shoving
+       "address@hidden@" in as the first list element since BSD make doesn't 
seem to
+       be able to handle backslashes for continuing comments on the following
+       line
 2000-12-28  Derek Price  <address@hidden>
        * NEWS (New in 1.4c): Added

reply via email to

[Prev in Thread] Current Thread [Next in Thread]