[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 07-prog-error.patch

From: Tom Tromey
Subject: Re: 07-prog-error.patch
Date: 28 Jan 2001 18:41:17 -0700

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

Akim>   * (prog_error): New.
Akim>   Spread its use.

This is fine.

Akim> +         &prog_error ("version is incorrect: $VERSION")
Akim> +             if ($VERSION !~ /([0-9]+)\.([0-9]+)([a-z])?/);

The automake style is to write trailing `if's without parens:

+               &prog_error ("version is incorrect: $VERSION")
+                   if $VERSION !~ /([0-9]+)\.([0-9]+)([a-z])?/;

(unless the condition requires a line break, then parens are added so
that tab will work -- sort of like the GNU style for C)

Could you make this change?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]