[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 11-more-phony.patch

From: Tom Tromey
Subject: Re: 11-more-phony.patch
Date: 28 Jan 2001 19:01:30 -0700

>>>>> "Akim" == Akim Demaille <address@hidden> writes:

Akim>   *,,,, Add a
Akim>   .PHONY target.
Akim>   * (handle_texinfo, handle_man_pages, handle_multilib)
Akim>   (handle_etags, handle_subdirs): Don't push into @phony.

This is ok.  BTW I like what you are doing here and elsewhere --
cleaning up some of the engineering problems in automake.

Akim> +    # FIXME: Suspicious name of phonies: there does not seem to be
Akim> +    # any `uninstall-data-recursive' target for instance.
Akim>      foreach $phonies ('', '-data', '-exec', 'dirs')
Akim>      {
Akim> - push (@phony, 'install' . $phonies . '-recursive');
Akim>   push (@phony, 'uninstall' . $phonies . '-recursive');
Akim> -    }

I agree and I think it is safe to simply delete the entire loop.  We
only have a single global `uninstall'; there are no -data or -exec
variants.  Also there isn't an uninstalldirs target either.  The only
remaining one is handled elsewhere in your patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]