Re: Improved Fortran support

[Tom Tromey]

>>>>> "Chris" == marq  <address@hidden> writes:

Hi.  I read your patch and I have some comments.

First, could you write a ChangeLog entry for it?

Chris> -        $non_c = 0 if $lang !~ /(objc|cxx|f77|ratfor)$/;
Chris> +        $non_c = 0 if $lang !~ 
/(objc|cxx|f77|ppf77|ratfor|f90|ppf90|f95|ppf95)$/;
 
It's about time to make this less ad hoc.  That's my problem, though,
not yours.  I have a patch to do this.

Chris> +        if 
(/AC_PROG_(F77|F90|F95|YACC|RANLIB|CC|CXXCPP|CXX|LEX|AWK|CPP|LN_S)/)

Where do AC_PROG_F90 and AC_PROG_F95 come from?

Chris> +        if (/AC_F90_LIBRARY_LDFLAGS/)
Chris> +        if (/AC_F95_LIBRARY_LDFLAGS/)

Likewise?

Chris> +sub lang_f90_finish
Chris> +{
Chris> +    # FIXME: this function can be called more than once.  We should
Chris> +    # arrange for it to only do anything the first time through.
Chris> +
Chris> +    local ($ltcompile, $ltlink) = &libtool_compiler;

Unfortunately with the cleanup work Akim has been doing the coding
standards for automake have changed.  Could you update your patch to
use `my' rather than `local'?

Chris>      return 'F77LINK'
Chris>          if defined $linkers{'F77LINK'};
Chris> +    return 'F90LINK'
Chris> +        if defined $linkers{'F90LINK'};
Chris> +    return 'F95LINK'
Chris> +        if defined $linkers{'F95LINK'};

Suppose a program has .f77, .f90, and .f95 sources.  Which linker
should be used?  I imagine this gets the answer backwards, however you
have to tell me.  My guess is that the F95 linker should take
precedence.

Tom