Re: 07-use-w.patch

[Akim Demaille]

Tom Tromey <address@hidden> writes:

> >> (&require_file_internal): Don't warn about installed files, just
> >> output on STDERR.
> 
> Akim> I'm fine with making this a warning again some day, but then it
> Akim> should be something like --warning=installing or something, set
> Akim> by default, but we need to be able to switch it off when running
> Akim> the test suite.  -W is needed first.
> 
> Sometimes this error is really an error.  That is why we save and
> optionally restore the exit status around the message printing.  Let's
> make this work correctly instead of breaking it.

I believe my patch is correct, note the $exit_status = 1.

@@ -7305,15 +7318,15 @@ sub require_file_internal
                }

                my $save = $exit_status;
+               $exit_status = 1;
                if ($is_configure)
                {
                    # FIXME: allow actual file to be specified.
-                   &am_conf_line_error ($configure_ac, $line,
-                                        "$message$trailer");
+                   print STDERR "$configure_ac:$line: $message$trailer\n";
                }
                else
                {
-                   &am_line_error ($line, "$message$trailer");
+                   print STDERR "$am_file.am:$line: $message$trailer\n";
                }
                $exit_status = $save if $suppress;
            }