automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 97.5-merge-finish-languages-dependencies.patch (Was: 98-no-depend2.p


From: Akim Demaille
Subject: Re: 97.5-merge-finish-languages-dependencies.patch (Was: 98-no-depend2.patch)
Date: 07 May 2001 19:03:38 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley)

Hi Tom,

| Which patches does the 97.5 patch supercede?

It was missing, I forgot to send it.

| Here are patches I still have:
| 
| Patch                         Status
| 99-ordering-changes           Missing ChangeLog entry
|                                 I have no idea what it does

It just swaps two commutative paragraphs, but makes it easier to read
the following patch.  Actually it should just be merged into the
following patches.  All of them might be merged, I had them as small
as I could to make them easier to check as most of them are just
reorganization + merging etc.

| 100-handle-languages-morphing-1       ChangeLog entry clearly mangled
|                                 Again its effect is unclear

At this stage handle_languages is composed of two loops over tge
languages (brought together by the previous patches).  It merges those
loops.

| 101-handle-languages-morphing-2       Probably ok

Just factoring some variables between paragraphs of the single loop,
since those variables were pertaining to two different loops before.

| 102-handle-languages-morphing-3 ChangeLog entry mangled
|                                 What does it do?

It factors code depending upon the same conditions ($lang->autodep ne
'no' && $use_dependencies).

| These patches are all probably ok.  They mostly seem to rearrange code
| in handle_languages.  But it looks like they got mangled somehow
| during the submission process.

Actually the ChangeLog entries are wrong, but the patches are right.

| I know they've been waiting a long time.  If they just rearrange the
| existing code, then go ahead and check them in.  

OK, I'm starting now, but I'm putting a tag handle-languages before
applying them if you want to revert something.

        Akim



reply via email to

[Prev in Thread] Current Thread [Next in Thread]