[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PR224

From: Robert Collins
Subject: Re: PR224
Date: Mon, 14 Jan 2002 08:02:53 +1100

----- Original Message -----
From: "Tom Tromey" <address@hidden>
> I looked at this PR.  Why do you want this change?
> Right now if you write:
>     AUTOMAKE_OPTIONS = subdir-objects
>     bin_PROGRAMS = wish
>     wish_SOURCES = generic/a.c generic/b.c
> ... you end up with `.deps/generic/a.Po'.
> The PR asks for `generic/.deps/a.Po'.

Yes. Simply put this breaks with any dependencies not in the current
sub-tree. And that is problematic. It _also_ leads to multiple .Po files
for a single source file, scattered around the build environment, which
'generic/.deps/a.Po' avoids....

if you write
  AUTOMAKE_OPTIONS = subdir-objects
  noinst_PROGRAMS = test1
  wish_SOURCES = $(top_srcdir)/src/a.c $(top_srcdir)/src/b.c test1.c
in $(top_srcdir)/test/

you end up with
where you need one of
or (better IMO)

> Does it make a difference?

Yes. Turning on subdir-objects breaks makefiles such as the above. And
yes convenience libraries can help.

> As I recall the reason things are done this way is that it is a little
> faster to compute the .Po file name when we don't have to change the
> directories.

I can accept that. Generating .deps/basename is easier. However simply
prepending the src->build translated path to the name ends up with the
correct result.

> On the other hand, changing this might let us have `..' path
> components.  I don't see that as a very high priority, but I'd welcome
> a patch.

Heh. Here is the original email
( and your
response (
(which I quote
"Actually, while this probably should be valid, right now it isn't.
Could you submit a PR for this?" :].

I'm not fluent with perl (and the support functions in automake) or I
would look closer at doing this myself (I've generated the odd automake
patch before).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]