[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] Another over zealous sanity check

From: Bruce Korb
Subject: Re: [patch] Another over zealous sanity check
Date: Thu, 22 Aug 2002 21:45:57 -0700

Tom Tromey wrote:
> >>>>> "Bruce" == Bruce Korb <address@hidden> writes:
> Bruce> +## DO NOT FORGET that there may be duplicates in the source and build 
> :-(
> When?
> Bruce> -           cp -pR $$d/$$file $(distdir)$$dir || exit 1; \
> Bruce> +           cp -pR $$d/$$file $(distdir)$$dir || :; \
> A patch like this really requires a rationale.

The rationale is that if a package regenerates a file that
is also distributed, then during "make distcheck" the file
will be made read-only in the source tree, copied to the
new tarball with permissions saved (i.e. read-only), then
an attempt is made top copy the generated file on top of
the read-only version.  The copy fails.  As I said in later
emails, a better solution is to just ensure that files 
copied out of the source tree have write permission 
enabled.  Directories, too.

Of course, what triggered the issue in my case has now
been avoided via some poorly documented SUBDIRS hackery,
so it is not crucial to me.  It is only a theoretical issue.

> Bruce> Attached are three files:
> I finally looked at this.  It sure is a lot of machinery for a faq!

... It takes some amount of machinery to adjust links to the
dynamic #SECnn stuff in the generated html.  Once it is there, ...

> I changed the references to `automake_toc.html' to `automake.html',
> but now the generated html doesn't look right.  For instance:

Even fixing the grep/sed expressions won't be a good idea.
It occurrs to me that if you have the faq reference the
single page html, then when someone clicks the link, they'll
start downloading the massive page.  Likely, many will give up.
The links need to be pointing into the page-per-node pages,
I think anyway.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]