[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: distcheck ignores conditionals

From: Ralf Wildenhues
Subject: Re: distcheck ignores conditionals
Date: Tue, 14 Sep 2010 20:13:05 +0200
User-agent: Mutt/1.5.20 (2010-08-04)

Hi Jeff,

* Daily, Jeff A wrote on Tue, Sep 14, 2010 at 07:07:55PM CEST:
> if INLINE_X86COPY_NEEDED # x86 cpu among other specific conditions
> if INLINE_X86COPY_OKAY # $(CC) handled GCC inline assembly okay
> libarmci_la_SOURCES += src/x86copy.c
> else
> if INLINE_X86COPY_WITH # help from gcc
> BUILT_SOURCES += src/x86copy_as.s
> libarmci_la_SOURCES += src/x86copy_as.s
> endif
> endif
> endif
> src/x86copy_as.s: src/x86copy.c
>         $(AM_CPPFLAGS) $(CPPFLAGS) -S $(MAYBE_PIC) -o $@  $<

Drop the BUILT_SOURCES line, it is not what you think, and not needed
here: it is to make sources *early* but only needed when make otherwise
doesn't know the source is built.  If you specify a rule for the source,
then make will always know.

Use nodist_libarmci_la_SOURCES instead of libarmci_la_SOURCES in both
cases, since you don't want the file distributed.  You may need to use
= instead of +=, or initialize the nodist_libarmci_la_SOURCES outside
and before the whole thing.

Then move the src/x86copy_as.s rule back into the conditional part where
it belongs.

Hope that helps.  Untested.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]