[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RE: [avr-gcc-list] [patch] #27663: missed-optimization transforming

From: Georg-Johann Lay
Subject: Re: RE: [avr-gcc-list] [patch] #27663: missed-optimization transforming abyte array to unsigned long
Date: Thu, 29 Jan 2009 14:45:27 +0100 (MET)

> Most of this patch has to do with using the "adjust_len" attribute and would
> be better off in the adjust_len patch:

Yes, I did this:
> > BTW: How can I generate a patch against the mentioned 
> > "adjust_len insn attribute"?. I think that would be more handy?

because I found no way to do the diff against the first patch.

I can generate (SVN+P1)-SVN (the adjust_len patch) and
(SVN+P1+P2)-SVN (the first patch for 27663), but I cannot generate
(SVN+P1+P2)-(SVN+P1), i.e. generate a patch P2 atop of SVN+P1 without removing 
all of
So it is not possible so split a complex patch into some logical parts that 
built on each other?

I removed all of P1 and attatched the proposed solution to #27663 again.

> This line should not be removed:
> @@ -1,4 +1,3 @@
> -;; -*- Mode: Scheme -*-

Sorry for including that in the patch. This line is very annoying and I am 
removin it in my working copy
and missed to rewrite it again.

First, IMHO advising an editor should not be done from within the compiler 
sources by foo-editor magic, should it?
Maybe someone else wants to tune his/her vi, jedit, Code::Blocks, TextPad, 
MicroSoft-Word by avr.md ;-)
Compiler sources should not bother with the editor they may be browsed with.

Second, it's annoying because it turns on scheme mode in emacs automatically 
knocks out the preferred mode in .emacs configuration. I e.g. prefer md-mode 
for md-files .

Third, anyone who wants to make emacs use scheme when visiting .md can advise 
emacs in his/her .emacs:

(setq auto-mode-alist
      (cons '("\\.md$" . scheme-mode)

This solution will also open other md-files in scheme-mode, even without emacs 
magic in every 
md-file that can be found in gcc sources....

Regards, Georg-Johann

Attachment: avr-27663_v2.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]