[avr-libc-commit] [2142] bug #30085: memcpy_P on XMega does not clr NVM.CMD before copy

[Joerg Wunsch]

Revision: 2142
          http://svn.sv.gnu.org/viewvc/?view=rev&root=avr-libc&revision=2142
Author:   joerg_wunsch
Date:     2010-06-08 20:13:54 +0000 (Tue, 08 Jun 2010)
Log Message:
-----------
bug #30085: memcpy_P on XMega does not clr NVM.CMD before copy
* include/avr/pgmspace.h: Mention that for Xmega devices,
these functions require NVM.CMD being set to 0x00.

Ticket Links:
:-----------
    http://savannah.gnu.org/bugs/?30085

Modified Paths:
--------------
    trunk/avr-libc/ChangeLog
    trunk/avr-libc/NEWS
    trunk/avr-libc/include/avr/pgmspace.h

Modified: trunk/avr-libc/ChangeLog
===================================================================
--- trunk/avr-libc/ChangeLog    2010-06-08 19:46:15 UTC (rev 2141)
+++ trunk/avr-libc/ChangeLog    2010-06-08 20:13:54 UTC (rev 2142)
@@ -1,5 +1,11 @@
 2010-06-08  Joerg Wunsch <address@hidden>
 
+       bug #30085: memcpy_P on XMega does not clr NVM.CMD before copy
+       * include/avr/pgmspace.h: Mention that for Xmega devices,
+       these functions require NVM.CMD being set to 0x00.
+
+2010-06-08  Joerg Wunsch <address@hidden>
+
        * include/avr/interrupt.h (cli, sei): Add a memory barrier,
        and cross-reference <util/atomic.h>.
 

Modified: trunk/avr-libc/NEWS
===================================================================
--- trunk/avr-libc/NEWS 2010-06-08 19:46:15 UTC (rev 2141)
+++ trunk/avr-libc/NEWS 2010-06-08 20:13:54 UTC (rev 2142)
@@ -117,8 +117,8 @@
   [#28901] Xmega header files with missing definitions for GPIO_t and CPU_t
   [#28574] Xmega D ADC struct missing registers
   [#29950] ATtiny167 SPM_PAGESIZE Discrepancy
+  [#30085] memcpy_P on XMega does not clr NVM.CMD before copy
 
-
 * Other changes:
 
   - Added 'avr35' architecture. Now 'MOVW' and 'LPM Rx, Z[+]' instructions

Modified: trunk/avr-libc/include/avr/pgmspace.h
===================================================================
--- trunk/avr-libc/include/avr/pgmspace.h       2010-06-08 19:46:15 UTC (rev 
2141)
+++ trunk/avr-libc/include/avr/pgmspace.h       2010-06-08 20:13:54 UTC (rev 
2142)
@@ -71,6 +71,10 @@
     it can become a problem if there are too many of these constants, or
     for bootloaders on devices with more than 64 KB of ROM.
     <em>All these functions will not work in that situation.</em>
+
+    \note For <b>Xmega</b> devices, make sure the NVM controller
+    command register (\c NVM.CMD or \c NVM_CMD) is set to 0x00 (NOP)
+    before using any of these functions.
 */
 
 #ifndef __PGMSPACE_H_