[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Main] Concentrate options.

From: Akim Demaille
Subject: Re: [Main] Concentrate options.
Date: 31 Aug 2001 18:12:29 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence)

>>>>> "akim" == akim  <address@hidden> writes:

akim> I think that for the moment I have been clear: I am not
akim> convinced, which stands for a simple no.  Maybe I need to pay
akim> more attention, but it is as simple as those two letters for the
akim> time being.

Which was indeed the case: I have been confused by the fact that some
options are marked with opt_percent, though, to me, they should be
opt_both.  In fact, I missed opt_both, and that's why I first rejected
your patch.  Please, check that you factored everything that could.

Also, it seems to me way too much information is public in your
patch.  Why should clients need to know your struct for instance.

Also, please stop putting random eol in ChangeLog.  To other people it
means separate checkins, which is not the case.  So just avoid, unless
it is conceptually really a different patch, which, again, is not the

Provided that

1. you fix the visibility issues (unless I missed something)
   and other factorization.

2. both Marc and Robert confirm that this still fits with their plans
   on `muscles' or whatever the name

you can apply it.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]