[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [trunk]: I-option2.patch

From: Marc Autret
Subject: Re: [trunk]: I-option2.patch
Date: 27 Nov 2001 16:52:16 -0500
User-agent: Gnus/5.0807 (Gnus v5.8.7) Emacs/20.7

Akim Demaille <address@hidden> writes:

> | +  char buff[32];
> This is not acceptable IMHO.

I agree!

> | +     if ((c < '!') && (c > '~'))
> I don't understand, and I shouldn't have to make efforts to understand.

Yes, that's true.
> Also, are you sure the _reader_ should go for a string instead of
> waiting for a string from the scanner.  I tend to think the approach
> is wrong.  The scanner knows how to swallow strings, you should rely
> on that.

I'm not sure that the scanner can do that the time being.
Moreover, the filenames can be built with all characters between
1 and 127 (ascii). That is a special manipulation.
Though it is, there is a problem with my patch...

> But I might be wrong, of course.


Marc Autret

reply via email to

[Prev in Thread] Current Thread [Next in Thread]