FYI: Kill warnings

[Akim Demaille]

There have been so many complaints about compilers that seem to be
much more picky than GCC, or more exactly, than my ability to check
GCC doesn't complain at all, that using -Werror seems the best
solutions to me.

Jim, xstrdup.c has to be adjusted to this end.

Index: ChangeLog
from  Akim Demaille  <address@hidden>

        * configure.in (WARNING_CFLAGS): Add -Werror when possible.
        (CFLAGS): Do not include the WARNING_CFLAGS here, since GNU
        Gettext doesn't compile cleanly, and dies with -Werror.
        * src/Makefile.am, lib/Makefile.am, tests/atlocal.in (CFLAGS):
        Include WARNING_CFLAGS here.
        * lib/xstrdup.c: Include xalloc.h, so that xstrdup be declared
        before being defined.

Index: Makefile.am
===================================================================
RCS file: /cvsroot/bison/bison/Makefile.am,v
retrieving revision 1.18.2.3
diff -u -u -r1.18.2.3 Makefile.am
--- Makefile.am 2001/09/27 15:24:45 1.18.2.3
+++ Makefile.am 2001/11/30 14:20:48
@@ -1,3 +1,18 @@
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+## 02111-1307  USA
+
 ## Process this file with automake to produce Makefile.in -*-Makefile-*-
 AUTOMAKE_OPTIONS = 1.5 check-news readme-alpha dist-bzip2

Index: configure.in
===================================================================
RCS file: /cvsroot/bison/bison/configure.in,v
retrieving revision 1.39.2.26
diff -u -u -r1.39.2.26 configure.in
--- configure.in 2001/11/26 17:13:05 1.39.2.26
+++ configure.in 2001/11/30 14:20:49
@@ -1,5 +1,7 @@
 # Configure template for GNU Bison.                   -*-Autoconf-*-
 #
+# Copyright 2001  Free Software Foundation, Inc.
+#
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 2 of the License, or
@@ -59,7 +61,7 @@
   BISON_WARNING(-Wshadow)
   BISON_WARNING(-Wstrict-prototypes)
   BISON_WARNING(-Wwrite-strings)
-  CFLAGS="$CFLAGS $WARNING_CFLAGS"
+  BISON_WARNING(-Werror)
 fi

 # Checks for libraries.
Index: lib/Makefile.am
===================================================================
RCS file: /cvsroot/bison/bison/lib/Makefile.am,v
retrieving revision 1.8.2.2
diff -u -u -r1.8.2.2 Makefile.am
--- lib/Makefile.am 2001/11/26 09:19:56 1.8.2.2
+++ lib/Makefile.am 2001/11/30 14:20:49
@@ -1,6 +1,23 @@
-## Process this file with automake to produce Makefile.in -*-Makefile-*-
+## Copyright 2001 Free Software Foundation, Inc.

+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+## 02111-1307  USA
+
 AUTOMAKE_OPTIONS = ansi2knr
+
+CFLAGS = @CFLAGS@ $(WARNING_CFLAGS)

 noinst_LIBRARIES = libbison.a

Index: lib/xstrdup.c
===================================================================
RCS file: /cvsroot/bison/bison/lib/xstrdup.c,v
retrieving revision 1.1
diff -u -u -r1.1 xstrdup.c
--- lib/xstrdup.c 2000/10/02 09:01:19 1.1
+++ lib/xstrdup.c 2001/11/30 14:20:49
@@ -1,5 +1,5 @@
 /* xstrdup.c -- copy a string with out of memory checking
-   Copyright (C) 1990, 1996, 1998 Free Software Foundation, Inc.
+   Copyright (C) 1990, 1996, 1998, 2001 Free Software Foundation, Inc.

    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -19,14 +19,6 @@
 # include <config.h>
 #endif

-#ifndef PARAMS
-# if defined PROTOTYPES || (defined __STDC__ && __STDC__)
-#  define PARAMS(Args) Args
-# else
-#  define PARAMS(Args) ()
-# endif
-#endif
-
 #if STDC_HEADERS || HAVE_STRING_H
 # include <string.h>
 #else
@@ -35,7 +27,7 @@

 #include <sys/types.h>

-char *xmalloc PARAMS ((size_t n));
+#include "xalloc.h"

 /* Return a newly allocated copy of STRING.  */

Index: src/Makefile.am
===================================================================
RCS file: /cvsroot/bison/bison/src/Makefile.am,v
retrieving revision 1.25.2.1
diff -u -u -r1.25.2.1 Makefile.am
--- src/Makefile.am 2001/11/28 10:32:48 1.25.2.1
+++ src/Makefile.am 2001/11/30 14:20:49
@@ -1,9 +1,28 @@
-## Process this file with automake to produce Makefile.in -*-Makefile-*-
-AUTOMAKE_OPTIONS = 1.4 ../lib/ansi2knr
+## Copyright 2001 Free Software Foundation, Inc.
+
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+## 02111-1307  USA
+
+AUTOMAKE_OPTIONS = ../lib/ansi2knr
+
 DEFS = @DEFS@ \
   -DBISON_SIMPLE=\"$(pkgdatadir)/bison.simple\" \
   -DBISON_HAIRY=\"$(pkgdatadir)/bison.hairy\" \
   -DLOCALEDIR=\"$(datadir)/locale\"
+
+CFLAGS = @CFLAGS@ $(WARNING_CFLAGS)

 # libintl.h in is build/intl, intl/libgettext.h in src/,
 # config.h in build/.
Index: tests/atlocal.in
===================================================================
RCS file: /cvsroot/bison/bison/tests/atlocal.in,v
retrieving revision 1.1.2.3
diff -u -u -r1.1.2.3 atlocal.in
--- tests/atlocal.in 2001/11/14 15:16:40 1.1.2.3
+++ tests/atlocal.in 2001/11/30 14:20:49
@@ -4,7 +4,7 @@

 # We need a C compiler.
 CC='@CC@'
-CFLAGS='@CFLAGS@'
+CFLAGS='@CFLAGS@ @WARNING_CFLAGS@'

 # We need to know if the compiler is GCC.
 GCC='@GCC@'