[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser

From: Joel E. Denny
Subject: Re: push parser
Date: Wed, 6 Dec 2006 21:21:31 -0500 (EST)

On Wed, 6 Dec 2006, Bob Rossi wrote:

> Before I submit a patch, I make sure the test suite works. Then I do a
> 'cp data/push.c data/yacc.c' and do a make install and make check.

It's also good to do a make maintainer-check before submitting your patch. 
Search HACKING to learn about that and configure --enable-gcc-warnings.

Without copying push.c to yacc.c, make maintainer-check fails for tests 93 
and 99.  Valgrind is detecting some errors.  Do you have Valgrind?

I've installed your patch, but we need to fix this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]