[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser

From: Bob Rossi
Subject: Re: push parser
Date: Thu, 7 Dec 2006 20:29:11 -0500
User-agent: Mutt/1.5.12-2006-07-14

On Thu, Dec 07, 2006 at 08:05:53PM -0500, Joel E. Denny wrote:
> On Thu, 7 Dec 2006, Bob Rossi wrote:
> > OK, here you go. This fixes the valgrind bug. It also makes changes the
> > return type of yypvarsinit from void* to struct yypvars* like suggested
> > earlier.
> >         * data/push.c (yypvarsinit): Change return type from void* to struct
> >         yypvars*. Initialized yylen. No longer cast to void* on return.
> > 
> Thanks for debugging this.  It appears that yylen doesn't need to be in 
> yypvars at all.  I installed the following patch instead.  At some point, 
> we should hunt down other unnecessary members as well.

OK, I didn't know which members should be in yypvars and which should
not. I was on the safe side, and put them all into yypvars. Obviously
the variables that need to keep there state across calls to yypushparse
need to stay in yypvars. So, after we tidy up some of these patches,
maybe you could look at the members and let me know which ones need to
keep there state across calls.

> By the way, if yypvarsinit is declared with b4_c_function_decl, shouldn't 
> it be defined with b4_c_function_def?

Hmm, I'll look into that.

Bob Rossi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]