bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser


From: Bob Rossi
Subject: Re: push parser
Date: Fri, 8 Dec 2006 16:12:41 -0500
User-agent: Mutt/1.5.12-2006-07-14

On Fri, Dec 08, 2006 at 04:00:08PM -0500, Joel E. Denny wrote:
> On Fri, 8 Dec 2006, Bob Rossi wrote:
> 
> > Here's a patch that renames all uses of pv to pstate. It changes all
> > uses of pvars to pstate. It also adds the prototypes for yypstateinit
> > and yypushparse to the bison generated header file.
> 
> Thanks, but I just noticed that your local variable pstate (formerly pv) 
> intrudes on the user namespace.  All Bison names should be in the yy (or 
> YY for most macros) namespace.  To eliminate another renaming patch, could 
> you just rewrite this one?  

Yup. I've got a patch coming. Is it ok to do this?
  struct yypstate *yypstate = ...;
and use yypstate as the type and variable name? If not, any suggestions?

Thanks,
Bob Rossi




reply via email to

[Prev in Thread] Current Thread [Next in Thread]