[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push parser

From: Joel E. Denny
Subject: Re: push parser
Date: Thu, 14 Dec 2006 15:45:55 -0500 (EST)

On Thu, 14 Dec 2006, Bob Rossi wrote:

> > Here are some more unresolved issues:
> > 
> > 1. Remove the yyparse prototype when %push-parser is specified.
> Hi Joel,
> Thanks for all the speedy work :)

Thanks for yours.

> 2006-12-14  Bob Rossi  <address@hidden>
>        * data/push.c (yyparse): Moved define to only be generated when not
>        in push-parser mode.
>        (yyparse): Moved prototype to only be declared when not in push-parser
>        mode.

Again, I think this isn't consistent with other ChangeLog entries.  

Here's one fairly strong guideline that might help you out: imperative 
mood describes what the patch is doing, but past tense describes something 
from before the patch.

Here's what I committed:

2006-12-14  Bob Rossi  <address@hidden>

        * data/push.c (yyparse): Remove the prototype and the #define when in
        push-parser mode.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]