[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] overquoting in implementation of %code and %defines

From: Paolo Bonzini
Subject: Re: [PATCH] overquoting in implementation of %code and %defines
Date: Sat, 13 Jan 2007 15:18:08 +0100
User-agent: Thunderbird (Macintosh/20061207)

Here's my version of your patch plus the `.' fix.  What do you think?

That's fine, except that I'd turn


into a m4_define. I still think it's overquoted because the user has no control over macros not in the b4_ namespace. But strictly speaking you're right, so let's move on.

As for the default issue, I was doing something like this in the Java skeleton:

m4_define([b4_prefix], [b4_get_percent_define([[prefix]], [[YY]])])

since this does not work:

m4_define([b4_prefix], [b4_get_percent_define([[prefix]])])
m4_define_default([b4_prefix], [[YY]])])


reply via email to

[Prev in Thread] Current Thread [Next in Thread]