[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] overquoting in implementation of %code and %defines

From: Joel E. Denny
Subject: Re: [PATCH] overquoting in implementation of %code and %defines
Date: Mon, 15 Jan 2007 03:09:48 -0500 (EST)

On Mon, 15 Jan 2007, Paolo Bonzini wrote:

> Well, given the extra long name of b4_get_percent_define (which unlike
> b4_get_percent_code is used many times throughout a skeleton) I'd "juggle yet
> another macro name for every variable name" if I use it frequently enough.
> Period, even if I don't want to define a default value.  :-)

As you can see in the C++ skeletons, I do that as well when a variable is 
pervasive.  But that's a different issue than a default value.

> If you want, I can take care of converting the existing skeletons to use the
> default argument instead of m4_define_default.

Please don't.  m4_define_default is preferable in my opinion.  I really 
see no reason to extend b4_get_percent_define, but I will just to settle 

> I can also take care of converting b4_get_percent_{define,code} to just
> b4_get_{define,code}.

I strongly prefer clarity over brevity in naming, but I'm usually alone on 

Eventually, we may need to ask Paul Eggert to offer his opinion and 
hopefully break the tie.

I've already updated the patch as I described previously.  I'll commit it 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]