[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] overquoting in implementation of %code and %defines

From: Paolo Bonzini
Subject: Re: [PATCH] overquoting in implementation of %code and %defines
Date: Mon, 15 Jan 2007 09:49:17 +0100
User-agent: Thunderbird (Macintosh/20061207)

1. b4_percent_define_foo is the value of foo. However, skeleton authors shouldn't need to touch this.

I'm instead proposing the special macro b4_percent_define(foo) -- also in Bison's output, and also for b4_percent_code(bar) -- but apart from this default yes, we agree. This kind of "foo(bar)" macro name is the same that I used in my change to how you implemented the check for unused %define/%code definitions.

We may eventually want a b4_is_defined_percent_define([[foo]]).

I'd say b4_has_percent_define/b4_has_percent_code instead.

I wonder if this sort of data encapsulation is worthwhile in M4.... What do you think?

I think it is. Take a look at how the different languages are implemented in autoconf, for example.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]