[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gettext for skeletons

From: Paolo Bonzini
Subject: Re: gettext for skeletons
Date: Thu, 18 Jan 2007 08:48:10 +0100
User-agent: Thunderbird (Macintosh/20061207)

In any case, I think this patch is mostly good, so I committed it.

Joel, please back out this patch.  If you look, e.g., at gcc, it is
current best practice to do gettext in the called functions, rather than
in the callee.  This should apply even to the functions in complain.c:
we should have gettext calls in warn, warn_at, complain, complain_at
rather than in all the callers of these functions.

The patch also complicates scanning the m4 output to the point that I'd
rather use Flex+Bison rather than just Flex!!!

I am working on extracting the messages directly from the skeletons,
without the need for @gettext markers.

Thanks for your understanding.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]