[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Handles several --enable-gcc-warnings
From: |
Joel E. Denny |
Subject: |
Re: [PATCH] Handles several --enable-gcc-warnings |
Date: |
Mon, 17 Nov 2008 10:54:24 -0500 (EST) |
On Mon, 17 Nov 2008, Joel E. Denny wrote:
> diff --git a/src/getargs.c b/src/getargs.c
> index 6b748c8..bc1cc64 100644
> --- a/src/getargs.c
> +++ b/src/getargs.c
> @@ -529,11 +529,14 @@ getargs (int argc, char *argv[])
> {
> char* name = optarg;
> char* value = strchr (optarg, '=');
> + char const * muscle_value = "";
> if (value)
> - *value++ = 0;
> - else
> - value = "";
> - muscle_percent_define_insert (name, command_line_location (),
> value);
> + {
> + *value++ = 0;
> + muscle_value = value;
> + }
> + muscle_percent_define_insert (name, command_line_location (),
> + muscle_value);
> }
> break;
Well, that can be a little simpler. I pushed the following to master.
>From 9ce405ce1dd2ff7d495dafe6201b87669549f98b Mon Sep 17 00:00:00 2001
From: Joel E. Denny <address@hidden>
Date: Mon, 17 Nov 2008 10:51:17 -0500
Subject: [PATCH] Simplify last patch slightly.
* src/getargs.c (getargs): Here.
diff --git a/src/getargs.c b/src/getargs.c
index bc1cc64..2a0611b 100644
--- a/src/getargs.c
+++ b/src/getargs.c
@@ -529,14 +529,10 @@ getargs (int argc, char *argv[])
{
char* name = optarg;
char* value = strchr (optarg, '=');
- char const * muscle_value = "";
if (value)
- {
- *value++ = 0;
- muscle_value = value;
- }
+ *value++ = 0;
muscle_percent_define_insert (name, command_line_location (),
- muscle_value);
+ value ? value : "");
}
break;
--
1.5.4.3