bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Prefer TESTSUITE_FLAGS.


From: Akim Demaille
Subject: Re: [PATCH] Prefer TESTSUITE_FLAGS.
Date: Wed, 26 Nov 2008 09:42:59 +0100


Le 25 nov. 08 à 23:48, Eric Blake a écrit :

Hi Eric,

TESTSUITEFLAGS is barely readable.

Maybe so, but it is the recommended spelling in the autoconf
manual, and it is consistent with CFLAGS, LIBTOOLFLAGS, ...
I'm not a fan of this patch.

Not to mention that the GNU Coding Standards state:

"Each program-name variable should come with an options variable
that is used to supply options to the program. Append ‘FLAGS’ to
the program-name variable name to get the options variable
name—for example, BISONFLAGS. (The names CFLAGS for the C
compiler, YFLAGS for yacc, and LFLAGS for lex, are exceptions to
this rule, but we keep them because they are standard.) Use
CPPFLAGS in any compilation command that runs the preprocessor,
and use LDFLAGS in any compilation command that does linking as
well as in any direct use of ld."
http://www.gnu.org/software/automake/manual/standards.html#Command-Variables

Finally, there was the time when libtool used AR_FLAGS instead
of ARFLAGS, and mass confusion ensued.

ARFLAGS is standard and documented as is in GNU Make's manual. Yet I thought I had read somehwere that the recommended usage for new programs was <program>_FLAGS, but I was wrong. For some reason MAKEINFO_FLAGS and TEXI2DVI_FLAGS seem to be exceptions according to GNU Make's documentation.

I'll revert this change, thanks for the prompt!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]