[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Warning about missing semicolon at end of action
From: |
Joel E. Denny |
Subject: |
Re: [PATCH] Warning about missing semicolon at end of action |
Date: |
Fri, 17 Apr 2009 00:34:20 -0400 (EDT) |
On Sat, 4 Apr 2009, Joel E. Denny wrote:
> On Sat, 22 Nov 2008, Di-an JAN wrote:
>
> > +2008-11-22 Di-an Jan <address@hidden>
> > +
> > + Implement the FIXME that ends an user action with a semicolon
> > + if it seems necessary.
>
> Do we still want this in 2.5? If so, I'll push a branch-2.5 that
> cherry-picks Di-an's patch from master and then adds the following patch.
>
> >From 2604d459092337cf1369dfaeb09f98c27d0089b3 Mon Sep 17 00:00:00 2001
> From: Joel E. Denny <address@hidden>
> Date: Sat, 4 Apr 2009 02:10:33 -0400
> Subject: [PATCH] Document semicolon warnings.
>
> * NEWS (2.5): In this new section.
> * tests/actions.at: Update copyright for previous patch.
> * tests/input.at: Likewise.
I pushed all that (though with a slightly different log entry) along with
the following cherry pick from master. I also pushed the above NEWS
change to master.
commit c4fae1ef488f25c1f6bd104d2cba1bcb1cfe865a
Author: Akim Demaille <address@hidden>
Date: Mon Dec 8 10:26:38 2008 +0100
Fix portability issue in the test suite.
* tests/local.at (AT_MATCHES_CHECK): New.
Based on Perl instead of Sed. Sed has too many portability
pitfalls, not ever Sed is GNU Sed.
* tests/actions.at (Fix user actions without a trailing semicolon):
Use it.
(cherry picked from commit 6617622c9aaa6ec3a9de5b0867421e2849b68b2f)