[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add new files for IELR and canonical LR implementation.

From: Joel E. Denny
Subject: Re: [PATCH] Add new files for IELR and canonical LR implementation.
Date: Thu, 14 May 2009 03:48:45 -0400 (EDT)

Hi Akim,

On Sun, 10 May 2009, Akim Demaille wrote:

> When listing files in, I put them one per line (or possibly the
> whole foo.* family), and M-x sort-lines them.  But on some collaborative
> project I work on we don't all have the same locale and the collating order
> differs.
> When I'm looking for a word in a dictionary, I don't expect the case to be
> relevant.  So really, I still think it is disturbing to have different types
> of file names.

Thanks for explaining.

> I'm fine with the identifiers within the files, but I am more troubled with
> the file names.  Especially because they are so few that they are a very
> visible exception.

I like that visibility as it signals the important shift in coding style 
inside the files.  Maybe I'd change my mind if I were affected by the 
locale issue, but I currently sort manually, for example.  
Anyway, I do agree that the file names are one of the least important 
parts of the new style.

> Unless you have bigger plans :)

I was considering very gradually migrating much of src/ to the new style.  
The camel case file names would help signal where the migration in the C 
code is complete.

However, I'm not adamant about migrating to the new style.  Unless you've 
changed your mind, I'll plan on converting the new file names to 
lower-case.suffix some time before the 2.5 release.  If you're not very 
enthusiastic about the rest of the new style either, then let me know, and 
I'll plan to change the new files completely to the old style.  
Otherwise, we should discuss the possibility of migrating other parts of 
src/ to the new style.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]