[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] symbolic names - a fixed version

From: Joel E. Denny
Subject: Re: [PATCH] symbolic names - a fixed version
Date: Fri, 29 May 2009 18:40:29 -0400 (EDT)
User-agent: Alpine 1.00 (DEB 882 2007-12-20)

On Sat, 30 May 2009, Alex Rozenman wrote:

> I am sending a fixed version after an additional testing I did this weekend.
> I also attached a number of tiny test grammars with very corner case errors
> (like eofs, wrong symbols, bad comments etc). As a result of this testing I
> fixed a small issue in scan-gram.l. Rest of the patch is exactly the same.

Thanks for doing that.

> Some technical questions:
> Can I help you with pushing and "cherry picking"?

Right now, we just need to find time to review the code.  Once we have, we 
can take care of pushing it.  Sorry for the delays.

> Is there any difference
> currently b/w the main branch and 2.4?

You mean master?  master will probably become the 2.6 release.

> Who is responsible for documentation
> and how we can handle this?

It would be great if you would extend the manual.  That might even help us 
with the code review as it should document what you currently expect the 
code to do.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]