Re: [PATCH] Fix a --enable-gcc-warnings problem.

[Joel E. Denny]

On Fri, 31 Jul 2009, Alex Rozenman wrote:

> I fixed errors belonging to my part of the code.

Thanks, Alex.

> There is still one
> remaining error:
> "src/scan-code.c:1759: warning: 'input' defined but not used"
> It's causing error in -Werror mode and the build is failed. I removed
> -Werror and checked that in the master branch it's only remaining issue.

I'm not seeing that one.  What are your versions of gcc and flex?

> In
> branch-2.5 there are couple of warnings, for example:
> ../../branch-2.5/lib/subpipe.c:134: warning: cast discards qualifiers from
> pointer target type
> ../../branch-2.5/lib/hash.c:931: warning: cast discards qualifiers from
> pointer target type

We've been ignoring gcc warnings from lib for years.  Some of it's gnulib 
not bison, and the rest of it isn't modified often.