[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: master: address some of the syntax-check errors
From: |
Akim Demaille |
Subject: |
Re: FYI: master: address some of the syntax-check errors |
Date: |
Sun, 19 Feb 2012 10:35:08 +0100 |
Hi Stefano!
Thanks for reading this. It must be even more painful to
read than to write :)
Le 18 févr. 2012 à 23:02, Stefano Lattarini a écrit :
> Hi Akim. Few random observations from an outsider …
Welcome in!
> On 02/18/2012 07:32 PM, Akim Demaille wrote:
>> This is perfectly uninteresting work. It's good that
>> it's done though. Will import to 2.5 too.
>>
>>
>> --- a/lib/bitset_stats.c
>> +++ b/lib/bitset_stats.c
>> - perror (_("Could not write stats file."));
>> + perror (_("cannot not write stats file"));
>>
> "cannot not"? A simple "cannot" would sound better ;-)
Fixed. And you made your entry in the THANKS file :)
From a7497ca6b6b3a853e0f231fe948b3981355b9e20 Mon Sep 17 00:00:00 2001
From: Akim Demaille <address@hidden>
Date: Sun, 19 Feb 2012 10:18:29 +0100
Subject: [PATCH] bitset: fix an incorrect error message.
* lib/bitset_stats.c: here.
Reported by Stefano Lattarini.
---
THANKS | 1 +
lib/bitset_stats.c | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/THANKS b/THANKS
index 93b2b4a..868e81e 100644
--- a/THANKS
+++ b/THANKS
@@ -98,6 +98,7 @@ Sebastian Setzer address@hidden
Sebastien Fricker address@hidden
Sergei Steshenko address@hidden
Shura address@hidden
+Stefano Lattarini address@hidden
Steve Murphy address@hidden
Summum Bonum address@hidden
Thiru Ramakrishnan address@hidden
diff --git a/lib/bitset_stats.c b/lib/bitset_stats.c
index f6b8714..dd14aab 100644
--- a/lib/bitset_stats.c
+++ b/lib/bitset_stats.c
@@ -284,7 +284,7 @@ bitset_stats_write (const char *file_name)
{
if (fwrite (&bitset_stats_info_data, sizeof (bitset_stats_info_data),
1, file) != 1)
- perror (_("cannot not write stats file"));
+ perror (_("cannot write stats file"));
if (fclose (file) != 0)
perror (_("cannot write stats file"));
}
--
1.7.9
> Ditto for other similar changes.
I didn't find other such issues.
>> --- a/etc/bench.pl.in
>> +++ b/etc/bench.pl.in
>> @@ -528,9 +528,8 @@ yylex (void)
>> static int
>> power (int base, int exponent)
>> {
>> + assert (0 <= exponent);
>> int res = 1;
>> - if (exponent < 0)
>> - exit (3);
>> for (/* Niente */; exponent; --exponent)
>>
> Unrelated to this patch, but it has caught my eye anyway ... why this
> comment in italian ("Niente") here?
For a change.
"Niente" is about all that is left from my studying italian :)