[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] skeletons: use header guards.

From: Akim Demaille
Subject: Re: [PATCH 1/3] skeletons: use header guards.
Date: Fri, 15 Jun 2012 16:22:00 +0200

Sorry I failed to send the introduction message (and actually lost

There are two shortcomings.

(i) When using yacc.c, parser.c now includes parser.h instead of
duplicating its content.  glr.c and already work like this.
Yet it means that parser.c must know where parser.h is in order to
#include it.  Currently all the implementation files (with yacc.c,
glr.c,, include the basename of header file, so -I
should suffice to find it.  But instead of basename, I am
contemplating the use of code from coreutils to compute relative
paths, to handle cases such as --output=a/b/c/my-parser.c
--defines=a/d/my-header.h (but, as I reported elsewhere, I am stunned
by the impact this gnulib modules would have, comments most welcome:

(ii) YYSTYPE and YYLTYPE are not renamed.  As already discussed, this
will be covered by some new %define api.prefix "foo" which will
deprecate %name-prefix.

I was clearly aiming at putting all this in 2.5.2, but, especially if
we decide that (ii) is important enough so that we wait for it to be
implemented, I start to believe that this should actually be 2.6 (and
master then would aim at 2.7).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]