[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] {maint} fix a test in header-self-contained

From: Akim Demaille
Subject: Re: [PATCH] {maint} fix a test in header-self-contained
Date: Wed, 3 Oct 2012 16:01:11 +0200

Le 3 oct. 2012 à 17:26, Theophile Ranquet a écrit :

> The previous changes seem to have introduced an issue with an include. This
> patch should address it.

Thanks!  Actually, I thought you'd post my patch too :)
The following one will be pushed before Théophile's.

commit 04a4684a513c1651c56fcc6d43e1049e5f07225d
Author: Akim Demaille <address@hidden>
Date:   Wed Oct 3 09:17:58 2012 +0200

    tests: check that headers are self contained
    Reported by Alexandre Duret-Lutz.
    * tests/ (Several parsers): here.

diff --git a/THANKS b/THANKS
index 8af0abb..09d6736 100644
--- a/THANKS
+++ b/THANKS
@@ -5,7 +5,7 @@ Airy Andre                address@hidden
 Akim Demaille             address@hidden
 Albert Chin-A-Young       address@hidden
 Alexander Belopolsky      address@hidden
-Alexandre Duret-Lutz      address@hidden
+Alexandre Duret-Lutz      address@hidden
 Andreas Schwab            address@hidden
 Andrew Suffield           address@hidden
 Angelo Borsotti           address@hidden
diff --git a/tests/ b/tests/
index 0524340..91fdb95 100644
--- a/tests/
+++ b/tests/
@@ -127,7 +127,8 @@ AT_SETUP([Several parsers])
 # -------------------------------
 # Generate and compile to *.o.  Make sure there is no (allowed) YY*
-# nor yy* identifiers in the header.
+# nor yy* identifiers in the header.  Check that headers are
+# self-contained, and can be compiled by a C++ compiler.
 [AT_BISON_OPTION_PUSHDEFS([%define api.prefix "$1_" $2])
 AT_DATA_GRAMMAR([$1.AT_SKEL_CC_IF([yy], [y])],
@@ -242,6 +243,18 @@ AT_TEST([x8], [%define api.pure %define api.push-pull 
 AT_COMPILE_CXX([parser], [[x[1-8].o -DCC_IS_CXX=$CC_IS_CXX]])
 AT_CHECK([./parser], [0], [[expout]])
+# Check that the headers are self-contained, and protected against
+# multiple inclusions.  While at it, check they are sane for C++.
+for h in *.h *.hh
+  # No shell expansion with AT_DATA.
+  cat >$ <<EOF
+#include "$h"
+#include "$h"
+  AT_COMPILE_CXX([$h.o])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]