bison-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] {maint} caret errors


From: Akim Demaille
Subject: Re: [PATCH 0/4] {maint} caret errors
Date: Tue, 4 Dec 2012 15:10:07 +0100

Hi Théophile,

Le 4 déc. 2012 à 15:26, Theophile Ranquet <address@hidden> a écrit :

> These patches introduce caret errors into Bison. For example,
> 
>    err.y:4.5-8: error: invalid reference: '$foo'
>     C: {$foo{bar} };
>         ^^^^

Nice work, thank!

Poor example though, unless you meant to have Bison digest some
Perl code.  Could you please use some C example instead, say
arithmetics :)

> I started implementing this in master, and as I rebased these changes into
> maint I noticed that some parts of the code made it difficult to support caret
> errors in some situations.  Therefore, the carets introduced now are a bit
> lacking in some aspects, sorry about that.  As a rule of thumb, don't be
> surprised if carets are absent from certain errors, this is the only easy way
> to keep a sane output (that I know of at the moment).

Merging will be plenty of fun!

> Also, the option right now is called "--flags", but I don't find this very
> insightful, so maybe we should call it "--features" or something instead? I am
> well aware that users will prefer the shorthand -f anyways, so this decision 
> is
> not life changing :)

We can also not provide a long option.  I have no strong opinion
here, and GCC does not give us the appropriate inspiration for the
long option name.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]