[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] grammar: free the association tracking graph
|
From: |
Théophile Ranquet |
|
Subject: |
Re: [PATCH] grammar: free the association tracking graph |
|
Date: |
Fri, 1 Feb 2013 12:41:44 +0100 |
2013/2/1 Akim Demaille <address@hidden>:
>
> Le 1 févr. 2013 à 00:59, Theophile Ranquet <address@hidden> a écrit :
>
>> The graph introduced by Valentin wasn't free'd after use.
>>
>> * src/symtab.c (cleanup_assoc): New, clear the array of linked lists with...
>> (cleanup_linkedlist): This, new.
>> (print_precedence_warnings): Call cleanup_assoc when done.
>> (print_assoc_warnings): Free used_assoc after use.
>
> Fine. I have a preference for assoc_free and linkedlist_free though.
Ok, I will rename those two functions as suggested.
> I know Bison is not consistent in this regard, but I much prefer
> having all the functions of module foo be named foo_*. Eventually
> I will rename the others too.