[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] Fix caret errors

From: Paul Eggert
Subject: Re: [PATCH 0/4] Fix caret errors
Date: Sun, 21 Apr 2019 10:22:47 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

Akim Demaille wrote:
2.  How should we quote source?
     a. Do like Clang
     b. Do like GCC
     c. Do like Bison, i.e., consider this is an unimportant issue,
        people should not use tabs anyway :)

There's another option:

   d. Do like GCC, except indent with a tab instead of a space.

(d) is used by 'diff -T'.

If I understand things correctly, (c) is of course the easiest but messes up alignment, which is annoying. (a) is nearly as easy and fixes the alignment but looks a bit worse and perhaps might introduce an ambiguity in the diagnostic output. (d) is also nearly as easy and fixes the appearance and ambiguity issues. (b) chews up fewer columns of output than (d), but is by far the most work to implement and requires Bison knowing the user's tab settings, which is fragile.

I suggest (d) as it fixes the alignment messup and is easy to do and this issue is not worth the hassle of (b). But that's just my opinion.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]