[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] Fixing all cex leaks
From: |
Akim Demaille |
Subject: |
Re: [PATCH 0/7] Fixing all cex leaks |
Date: |
Fri, 22 May 2020 08:17:10 +0200 |
Hi Vincent!
> Le 22 mai 2020 à 04:13, Vincent Imbimbo <address@hidden> a écrit :
>
> Hey Akim,
> I think I got all of them. I ended up implementing some of the stuff we
> discussed to fix these.
> The state-item graph edges are now kept in the structs. I also added typedefs
> / API for derivation_list and parse_state_list.
I saw that. That's great! I'm pushing this right now to the CI, we should
have the answer soon:
https://travis-ci.org/github/akimd/bison/builds/689920732. But maybe I will
have pushed again before you actual check: please look for the latest
(leftmost) build of the cex branch here:
https://travis-ci.org/github/akimd/bison/branches.
This is great stuff!
FYI, I have fixed some of your commit messages for a few issues:
- fit into 80 cols
- the colon is after the parentheses, not before
- repeat the * when the list of files wraps because of the width limit
* src/counterexample.c: (unifying_counterexample) always free stage3result when
it exists.
=>
* src/counterexample.c (unifying_counterexample): Always free
stage3result when it exists.
Cheers!
- [PATCH 0/7] Fixing all cex leaks, Vincent Imbimbo, 2020/05/21
- [PATCH 1/7] cex: dervation reference counting, Vincent Imbimbo, 2020/05/21
- [PATCH 2/7] cex: fix parse state leaks, Vincent Imbimbo, 2020/05/21
- [PATCH 3/7] cex: fix lssi leaks, Vincent Imbimbo, 2020/05/21
- [PATCH 4/7] cex: fix counterexample leak, Vincent Imbimbo, 2020/05/21
- [PATCH 5/7] cex: fix miscellaneous leaks, Vincent Imbimbo, 2020/05/21
- [PATCH 6/7] cex: fix bad reference counting, Vincent Imbimbo, 2020/05/21
- [PATCH 7/7] cex: replace state-item data structures, Vincent Imbimbo, 2020/05/21
- Re: [PATCH 0/7] Fixing all cex leaks,
Akim Demaille <=