[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for Dlang support] Push parser

From: Akim Demaille
Subject: Re: [PATCH for Dlang support] Push parser
Date: Sat, 27 Mar 2021 07:35:47 +0100

Hi Adela,

> Le 23 mars 2021 à 00:03, Adela Vais <> a écrit :
> Hello Akim,
> I added the push parser support.

Excellent!  This looks very nice.

I see that you have keep the possibility for the regular pull parser
to use local variables.  Have you benchmarked if this is worth the
effort?  Because it there's no measurable difference, you may just
as well always use attributes of the parser object.  That would simplify
the skeleton.

The patch does not apply cleanly.  Could you please rebase it and
send it again?

> I have a question, I know you said at some point that you want to
> demonstrate the push parser support in the examples. How should I go about
> it? A new, 'pushcalc' example, based on 'calc'? Or something similar to
> Java, where the 'calc' example also uses this directive?

I don't think we need too many examples.  So I would go with keeping
a super simple one, and have the other one grow with all the bells
and whistles, a bit like what the bistromathic example does in C.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]