[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for Dlang support] Push parser

From: Adela Vais
Subject: Re: [PATCH for Dlang support] Push parser
Date: Fri, 2 Apr 2021 02:23:00 +0300

Hello Akim,

Thank you for the feedback!

În sâm., 27 mar. 2021 la 08:35, Akim Demaille <> a scris:

> I see that you have keep the possibility for the regular pull parser
> to use local variables.  Have you benchmarked if this is worth the
> effort?  Because it there's no measurable difference, you may just
> as well always use attributes of the parser object.  That would simplify
> the skeleton.

I benchmarked it, and there is no measurable difference. I put the
variables as class attributes.

> The patch does not apply cleanly.  Could you please rebase it and
> send it again?


> > I have a question, I know you said at some point that you want to
> > demonstrate the push parser support in the examples. How should I go
> about
> > it? A new, 'pushcalc' example, based on 'calc'? Or something similar to
> > Java, where the 'calc' example also uses this directive?
> I don't think we need too many examples.  So I would go with keeping
> a super simple one, and have the other one grow with all the bells
> and whistles, a bit like what the bistromathic example does in C.

I added the push parser to the 'calc' example.


Attachment: 0001-d-add-push-parser-support.patch
Description: Binary data

Attachment: 0002-d-demonstrate-the-push-parser.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]