Re: [bongo-devel] bongo-sprinkle-until-saturated pops up the playlist

[Daniel Brockman]

Hi Anthony,

> I've just run into bongo-sprinkle and related; I'm liking these
> functions, so they'll probably supersede random-playback-mode for me

Cool.  Thank you for the feedback; you're the first person
to say anything about those since I introduced them.

I'm glad you like them!

> (I haven't really checked the whole 'track selection and
> marks' thing yet, though).

What do you mean?  The way it interacts with sprinkling?

(You are talking about your `play mask', --- as I once
called it, --- right?)

> I do have a gripe with bongo-sprinkle-until-saturated, though. The
> playlist buffer is popped up every time a new track is played,
> creating a new window in the process (especially annoying when
> there are already two or three windows around).

Oops.  That behavior was not intended.

> I gather bongo-sprinkle-until-saturated is supposed to work for 'add
> random tracks from library without any prompting', so I don't see why
> the playlist buffer should be displayed in the foreground.

I must admit to poor testing practices.

> Assuming there is indeed no rationale behind this behaviour,

Indeed, you are absolutely right.

> adding (save-window-excursion) to
> bongo-sprinkle-until-saturated should do the trick.

I chose another solution wherein all enqueue functions now
take an optional argument controlling whether the playlist
may be displayed as a side-effect.  This argument is set to a
non-nil value when enqueue commands are called interactively.

Callers like `bongo-sprinkle' simply omit the argument ---
preventing the side-effect of displaying the playlist.

Please confirm that this fixes the bug you are seeing.


Thanks a lot,

-- 
Daniel Brockman <address@hidden>

P.S. I just pushed 7 patches from April 11 which I'd announced
on bongo-patches but forgot to push to the main repository.