bongo-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bongo-patches] Don't use `case' inside `interactive'


From: Daniel Jensen
Subject: [bongo-patches] Don't use `case' inside `interactive'
Date: Tue, 19 Jun 2007 20:20:45 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux)

I think this is strange. Can you reproduce the bug? Apparently, `case'
is not macroexpanded inside `interactive' in `bongo-insert-file' during
byte-compilation. I get an error later when I press `i' in a buffer.

Anyway, here's a patch.

diff -Naur bongo-old/bongo.el bongo-new/bongo.el
--- bongo-old/bongo.el  2007-06-19 18:46:49.000000000 +0200
+++ bongo-new/bongo.el  2007-06-19 18:47:56.000000000 +0200
@@ -7766,9 +7766,9 @@
   (interactive
    (list (let ((file-string
                 (read-file-name
-                 (case bongo-insert-whole-directory-trees
-                   ((nil ask) "Insert file or directory: ")
-                   (otherwise "Insert file or directory tree: "))
+                 (if (member bongo-insert-whole-directory-trees '(nil ask))
+                     "Insert file or directory: "
+                   "Insert file or directory tree: ")
                  default-directory nil nil
                  (when (eq major-mode 'dired-mode)
                    (dired-get-filename t)))))





reply via email to

[Prev in Thread] Current Thread [Next in Thread]