Re: [Bug-apl] Support for help command in emacs-mode

[Elias Mårtenson]

To me, it's a lot better if the primary code stays in the main GNU APL repository.

Jürgen, 

We've discussed in the past the possibility of moving to a public development repository where all of us can create commit requests, but at the time you expressed concerns with that model. 

Perhaps we can revisit this? Right now the development is kind of spread out over multiple repositories, which makes this slightly more complicated than it has to be. In my opinion, the best solution would be to have a single main repository for GNU APL, where I can maintain the emacs subdirectory. 

That said, you're the maintainer, and I can follow any methodology you want.

Regards, 

Elias 

On 8 Jan 2018 12:29 am, "Alexey Veretennikov" <address@hidden> wrote:

Hi, 

The files I've attached are based on the sources from SVN, not git.

Br

/Alexey

On Jan 7, 2018 4:52 PM, "Juergen Sauermann" <address@hidden> wrote:

Hi,

they are actually used (I sync my sources from your git repo). I suppose that you applied
Alexey's patch to your sources and the result doesn't compile when I fetch the changes from
your git repo.

I would prefer if the two repos remain in sync as long as they both exist.

If you would simply remove your emacs repo then I would become responsible
for the emacs sources in GNU APL which is close to impossible because I have no
idea how emacs works.

Best Regards,
/// Jürgen

On 01/07/2018 04:19 PM, Elias Mårtenson wrote:

That's OK. The C++ sources in my repository isn't actually used. I should probably remove them from the gnu-apl-mode repository.

The code in the main GNU APL repository is the official source.

Regards,

Elias

On 7 January 2018 at 22:53, Juergen Sauermann <address@hidden> wrote:

Hi,

it seems like Elias' sources in git are slightly out of sync with the current GNU APL sources.
For example (emacs.hh around line 55):

-    return string((const char *)&utf[0], utf.size());
+    return string((const char *)(utf.get_items()), utf.size());

Best Regards,
/// Jürgen

On 01/07/2018 02:12 PM, Elias Mårtenson wrote:

Thank you for this work. This is something have planned to do for a while but never got around to.

I merged your changes and tested, and it all seems to work fine. I'll merge this into gnu-apl-mode, but Jürgen needs to do the same on his side before this is complete.

Regards,

Elias

On 7 January 2018 at 18:48, Alexey Veretennikov <address@hidden> wrote:

Hi Juergen, Elias and all,

Some time ago we have been discussing the idea to move help from
gnu-apl-mode in Emacs into the GNU APL itself.

Now since we have a help in GNU APL, I've implemented network command in
emacs_mode part of GNU APL which will send requested help as a list of
S-expressions ready to be parsed on a Emacs side. See patches and new
files attached (to be applied/added into the src/emacs_mode directory)

I've also implemented support for this command in emacs-mode,
corresponding pull-request is here:
https://github.com/lokedhs/gnu-apl-mode/pull/26

This combination has been tested locally.
The changes are backwards-compatible.



--
Br,
/Alexey