[Bug-apl] Issues building with GCC 8.1.1

[Fred Weigel]

I just updated to Fedora 28. Had some issues compiling GNU APL
                                       
                    ______ _   __ __  __    ___     ____   __ 
                   / ____// | / // / / /   /   |   / __ \ / / 
                  / / __ /  |/ // / / /   / /| |  / /_/ // /  
                 / /_/ // /|  // /_/ /   / ___ | / ____// /___
                 \____//_/ |_/ \____/   /_/  |_|/_/    /_____/
                                       
                 Welcome to GNU APL version 1.7 local / 1050M
                                       
                Copyright (C) 2008-2016  Dr. Jürgen Sauermann
                       Banner by FIGlet: www.figlet.org
                                       
                This program comes with ABSOLUTELY NO WARRANTY;
                          for details run: apl --gpl.
                                       
     This program is free software, and you are welcome to redistribute
it
         according to the GNU Public License (GPL) version 3 or later.
                                       
DUMPED 2017-08-06  18:41:50 (GMT-4)


Note that this has some local changes (memory mapping support, and some
other minor changes), thus the designation "1.7 local".

But, these notes apply to the unaltered version 1050 as well (and the
pragma notes apply to 1047).

c++ (GCC) 8.1.1 20180502 (Red Hat 8.1.1-1)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is
NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
PURPOSE.

This version of GCC is more stringent. The following pragmas can be
added to successfully compile:

LibPaths.cc:#pragma GCC diagnostic ignored "-Wstringop-truncation"
Quad_SVx.cc:#pragma GCC diagnostic ignored "-Wformat-truncation"
Svar_DB.cc:#pragma GCC diagnostic ignored "-Wformat-truncation"
Svar_record.cc:#pragma GCC diagnostic ignored "-Wformat-truncation"
Svar_record.hh:#pragma GCC diagnostic ignored "-Wclass-memaccess"

If RATIONAL_NUMBERS_DEFINED is defined:

FloatCell.cc line 527

 const FloatCell inv_B(denom, numer);
 
        should be

 const FloatCell inv_B(B_denom, B_numer);
 
  
 IntCell.cc line 533
 
 const APL_Integer b = get_int_value();
 
        should be
 
 APL_Integer b = get_int_value();
 
        and
 
 const APL_Integer a = A->get_int_value();
 
        should be
 
 APL_Integer a = A->get_int_value();

(these, because of a = -a and b = -b)

Fred Weigel