[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25563: 11.90; Many predicates in TeX-view-predicate-list-builtin don

From: Ikumi Keita
Subject: bug#25563: 11.90; Many predicates in TeX-view-predicate-list-builtin don't work.
Date: Fri, 03 Feb 2017 19:20:34 +0900

Hi Tassilo,

>> 1. Isn't the the regexp \`a5paper\|a5comb\' for paper-a5 really intended
>> as \`\(?:a5paper\|a5comb\)\' ?  Similar question goes to the regexp
>> for paper-a4, too.

> Oh, I didn't think about it.  But after a short test it seems that
> foo\|bar is equivalent to \(foo\|bar\) and not to fo\(o\|b\)ar which you
> seem to expect (and which sounded more plausible to me, too).

Ah, no, my concern is in the way how "\`" and "\'" are interpreted.  The
original regexp \`a5paper\|a5comb\' means
"\`a5paper" or "a5comb\'",
"\`a5paper\'" or "\`a5comb\'".
That is, \`a5paper\|a5comb\' matches with "a5paperXYZ" and "XYZa5comb"
while \`\(?:a5paper\|a5comb\)\' does not.

>> 2. `LaTeX-auto-cleanup' treats "package" and "Package" equally at the
>> part
>> (if (or (string-equal "package" class)
>> (string-equal "Package" class))
>> .  Thus the later part
>> (cond (equal class "class")
>> (add-to-list 'TeX-auto-file "latex2e"))
>> shuold also treat "class" and "Class" equally, shouldn't it?

> Yes, makes sense.

> Could you do me a favor and submit a one-in-all patch which also
> contains your changes from your later 2 changes with a ChangeLog-like
> commit message?

OK, the patch is attached at the last of this mail.

> Bye,
> Tassilo

> BTW: You are a contributor since a very long time (12 years!) and I
> completely trust your ability to not mess up things beyond repair.  So
> I'd happily give you push access to our repository if you want to.
> Interested?

Thank you very much.  I would like to recieve that honor.  Please tell
me what I should do next.

Ikumi Keita

Attachment: diff
Description: small patch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]