Re: Incorrect documentation for AC_ERLANG_SUBST_INSTALL_LIB_DIR

[Eric Blake]

[adding autoconf-patches; replies can probably drop bug-autoconf]

On 05/11/2010 12:10 PM, David Reiss wrote:
>> Since I'm not an erlang user, I'll leave it to your judgment which is
>> more useful.  But for backwards compatibility, I'd prefer a patch along
>> the lines of the former (better to change the docs to match reality,
>> than to change reality and break configure.ac that happened to depend on
>> the old semantics).
>>
> Here's a patch.  Should I send it to autoconf-patches instead?

autoconf-patches is preferred, but I read both lists, and have been
known to apply patches sent to bug-autoconf in the past without any
questions.

> I license this patch under the GFDL.  The commit message is public domain.

Unfortunately, the FSF does not go by email disclaimers like this; in
order to have legal significance in a courtroom defense of a copyright
claim, they prefer that all disclaimers be done through signatures and
snail mail.  On the other hand, your contribution is small enough to not
need copyright disclaimer (hence the notation '(tiny change)' that I am
putting in the ChangeLog for your entry), so there is nothing wrong with
applying your patch.

> +++ b/doc/autoconf.texi
> @@ -8360,8 +8360,7 @@ Set the @code{ERLANG_INSTALL_LIB_DIR} output variable 
> to the directory into
>  which every built Erlang library should be installed in a separate
>  subdirectory.
>  If this variable is not set in the environment when @command{configure} runs,
> -its default value is @code{$ERLANG_LIB_DIR}, which value is set by the
> address@hidden macro.
> +its default value is @code{$libdir/erlang/lib}.
>  @end defmac

I slightly tweaked this hunk, to use ${libdir} rather than $libdir, to
actually match the code.

>  
>  @defmac AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR (@var{library}, @var{version})
> @@ -8372,9 +8371,7 @@ Set the @address@hidden output variable to the
>  directory into which the built Erlang library @var{library} version
>  @var{version} should be installed.  If this variable is not set in the
>  environment when @command{configure} runs, its default value is
> address@hidden/@address@hidden, the value of the
> address@hidden variable being set by the
> address@hidden macro.
> address@hidden/erlang/lib/@address@hidden

I dropped this hunk; it already matches the code (other than whether it
used $ERLANG... or ${ERLANG...}).

Thanks again for reporting and proposing a fix for this matter.  After
adding a ChangeLog entry and adding you in THANKS, I have pushed the
updated patch.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature